Skip to content

Conversation

@dminuoso
Copy link

@dminuoso dminuoso commented Mar 6, 2025

Fixes #47

Seems to work fine.

One point of interest, services.authentik-rac.enable would conflict with services.guacamole-server.enable because authentik-rac starts and manages guacd internally. We could perhaps mkForce the latter to false?

@GeoffreyFrogeye GeoffreyFrogeye mentioned this pull request Apr 6, 2025
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the pathWith change is still missing.

@dminuoso
Copy link
Author

Fixed as requested.

@dminuoso dminuoso requested a review from Ma27 October 10, 2025 08:29
@dminuoso dminuoso force-pushed the add-rac-outpost branch 4 times, most recently from 9bc67dc to 1aac5d4 Compare October 20, 2025 10:31
@dminuoso
Copy link
Author

Anything else missing here? Would love to get this into main.

@Ma27
Copy link
Member

Ma27 commented Oct 27, 2025

The tests are red because this doesn'te valuate on aarch64-linux anymore. So this feature should be made x86_64-linux only. That being said, I'll try to land #50 first, then we can ship this, but w/o the overhead in the closure for everyone else (I know that this wouldn't have happened with the BindReadOnlyPaths approach, but I still think that early patching paths in the build is the superior approach).

@Ma27
Copy link
Member

Ma27 commented Oct 27, 2025

Force-pushed a commit that adds this to its own output.

Would've loved to assert on this, i.e.

buildGoModule {
  # ...
  __structuredAttrs = true;
  outputChecks.out = {
    disallowedRequisites = [ guacamole-server ];
  };
}

but apparently buildGoModule doesn't support structured attrs :(

Co-authored-by: Maximilian Bosch <[email protected]>
@Ma27
Copy link
Member

Ma27 commented Oct 27, 2025

@dminuoso just pushed a change that also turns the thing off and throws an assertion error if guacamole-server is not available (e.g. aarch64-linux). Please double-check if this is OK for you or if I did regress something (not using this feature myself, sorry).

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise LGTM.

Waiting for @dminuoso still to check if I didn't regress something with my last push before merging.

@dminuoso
Copy link
Author

@Ma27 Works fine on our servers. Can be merged.

@Ma27 Ma27 merged commit ea1e06f into nix-community:main Oct 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RAC outpost missing

3 participants