-
-
Notifications
You must be signed in to change notification settings - Fork 27
Add RAC outpost #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RAC outpost #48
Conversation
989b139 to
b74b3f0
Compare
Ma27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the pathWith change is still missing.
4c04d5f to
401e0d4
Compare
|
Fixed as requested. |
401e0d4 to
677cb54
Compare
9bc67dc to
1aac5d4
Compare
|
Anything else missing here? Would love to get this into main. |
|
The tests are red because this doesn'te valuate on aarch64-linux anymore. So this feature should be made x86_64-linux only. That being said, I'll try to land #50 first, then we can ship this, but w/o the overhead in the closure for everyone else (I know that this wouldn't have happened with the BindReadOnlyPaths approach, but I still think that early patching paths in the build is the superior approach). |
|
Force-pushed a commit that adds this to its own output. Would've loved to assert on this, i.e. buildGoModule {
# ...
__structuredAttrs = true;
outputChecks.out = {
disallowedRequisites = [ guacamole-server ];
};
}but apparently |
Co-authored-by: Maximilian Bosch <[email protected]>
|
@dminuoso just pushed a change that also turns the thing off and throws an assertion error if guacamole-server is not available (e.g. aarch64-linux). Please double-check if this is OK for you or if I did regress something (not using this feature myself, sorry). |
Ma27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-wise LGTM.
Waiting for @dminuoso still to check if I didn't regress something with my last push before merging.
|
@Ma27 Works fine on our servers. Can be merged. |
Fixes #47
Seems to work fine.
One point of interest,
services.authentik-rac.enablewould conflict withservices.guacamole-server.enablebecause authentik-rac starts and managesguacdinternally. We could perhaps mkForce the latter to false?